Improving the connection setup instructions #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBZA
approved these changes
Aug 26, 2025
| <template> | ||
| <div class="row"> | ||
| <p v-if="(settingsInfo?.broker_settings.length ?? 0 > 0) || (!isBrokerTransport && useIsMonitoringEnabled())"> | ||
| <p v-if="(settingsInfo?.broker_settings.length ?? 0 > 0) || ((settingsInfo?.monitoring_settings.length ?? 0 > 0) && useIsMonitoringEnabled()) || (settingsInfo?.service_control_settings.length ?? 0 > 0)"> |
There was a problem hiding this comment.
This logic is a bit hard for me to parse (especially with the .monitoring_settings and .service_control_settings differences which looks very similar to the rest to the code).
Is it possible to put this behind a named function to make it more readable?
v-if="shouldDisplayCollectionInstructions() or something like that?
There was a problem hiding this comment.
I have refactor this, thanks for pointing it out
This improves the rendering of the instructions so that it support empty list of instructions.
johnsimons
force-pushed
the
john/better-instructions
branch
from
c7c3d0f to
99f41e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the rendering of the instructions so that it supports an empty list of instructions, which is added in Particular/ServiceControl#5104.
So for ASQ, we were displaying:
and now we display:
For MSMQ we were displaying:
and now we display:
For broker transports such as ASB we were displaying:
and now we display:
Note
This PR is not 100% backwards compatible, so if the user upgrades SC to latest and does not upgrade SP, they will see:
which is not too bad.